Skip to content

Conversation

periklis
Copy link
Contributor

@periklis periklis commented Oct 7, 2024

@periklis periklis requested a review from saswatamcode October 7, 2024 09:44
@periklis periklis self-assigned this Oct 7, 2024
@xperimental
Copy link
Contributor

Already talked to Peri about this, just leaving this here so that others are aware as well:

The k8s 1.30 libraries require Go 1.22, which we currently can not update to due to a bug in relation to FIPS. It looks as if a fix might be happening soon, but as long as the fix is not available, this can not be merged. An option would be to just upgrade to 1.29 as an intermediary step. And we're currently discussing if the issue is actually relevant to us (mostly because I don't understand the mechanism by which it is affecting us).

@periklis periklis changed the title Bump k8s to 1.30.5 Bump go1.22 and k8s 1.30.5 Oct 7, 2024
@periklis
Copy link
Contributor Author

periklis commented Oct 7, 2024

Already talked to Peri about this, just leaving this here so that others are aware as well:

The k8s 1.30 libraries require Go 1.22, which we currently can not update to due to a bug in relation to FIPS. It looks as if a fix might be happening soon, but as long as the fix is not available, this can not be merged. An option would be to just upgrade to 1.29 as an intermediary step. And we're currently discussing if the issue is actually relevant to us (mostly because I don't understand the mechanism by which it is affecting us).

Re-tested go 1.22 binaries on a OCP 4.17 FIPS cluster with an up2date runc and all works as expected. I cannot disclose the exact details here but it seems an older version of runc exec was unable to run binaries which used dlopen for openssl.

@periklis periklis force-pushed the k8s-bump-1.30 branch 4 times, most recently from 841ee40 to 88bdd68 Compare October 7, 2024 17:43
@@ -1,5 +1,5 @@
module _ // Auto generated by https://github.com/bwplotka/bingo. DO NOT EDIT

go 1.19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we update the go version on .bingo/golangci-lint.mod but not in here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is what bingo is doing internally. golangci-lint requires go 1.22 but faillint not?!?

@periklis periklis force-pushed the k8s-bump-1.30 branch 2 times, most recently from 7b9a7df to 18ffe57 Compare October 9, 2024 10:58
Copy link
Contributor

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@periklis periklis merged commit 0b7b3e4 into observatorium:main Oct 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants