-
Notifications
You must be signed in to change notification settings - Fork 70
Bump go1.22 and k8s 1.30.5 #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b83dec5
to
e62fe5c
Compare
Already talked to Peri about this, just leaving this here so that others are aware as well: The k8s 1.30 libraries require Go 1.22, which we currently can not update to due to a bug in relation to FIPS. It looks as if a fix might be happening soon, but as long as the fix is not available, this can not be merged. An option would be to just upgrade to 1.29 as an intermediary step. And we're currently discussing if the issue is actually relevant to us (mostly because I don't understand the mechanism by which it is affecting us). |
e62fe5c
to
3c12bbc
Compare
Re-tested go 1.22 binaries on a OCP 4.17 FIPS cluster with an up2date runc and all works as expected. I cannot disclose the exact details here but it seems an older version of runc exec was unable to run binaries which used |
841ee40
to
88bdd68
Compare
@@ -1,5 +1,5 @@ | |||
module _ // Auto generated by https://github.com/bwplotka/bingo. DO NOT EDIT | |||
|
|||
go 1.19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we update the go version on .bingo/golangci-lint.mod
but not in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is what bingo is doing internally. golangci-lint requires go 1.22 but faillint not?!?
7b9a7df
to
18ffe57
Compare
18ffe57
to
962a375
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
cc @JoaoBraveCoding @xperimental