logs: re-introduce rules filtering for Prometheus API as this is still not supported by Loki #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoBraveCoding
changed the title
JoaoBraveCoding
force-pushed
the
LOG-6148
branch
from
e8ad52b to
9ab022f
Compare
not supported by Loki
JoaoBraveCoding
force-pushed
the
LOG-6148
branch
from
9ab022f to
0b653d4
Compare
xperimental
reviewed
Mar 4, 2025
| ErrorType string `json:"errorType"` | ||
| } | ||
|
|
||
| func newModifyResponseProm(logger log.Logger, labelKeys map[string][]string) func(*http.Response) error { |
There was a problem hiding this comment.
Some of the error code-paths are not covered by the current set of tests. Should we add one or more tests to cover some of them? Most of them seem to be simple cases, so it's more a question of "completeness" and if it's worth the effort (not talking about all the paths where it's an IO operation or marshalling).
There was a problem hiding this comment.
Added tests for alerts let me know if you were also referring to anything else
xperimental
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #578 we completely removed the filtering code and relied only on the query parameter for Loki to filter the rules. However, the filtering only works for the Loki API and not for the Prometheus API
Fixes https://issues.redhat.com/browse/LOG-6148