Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sum encoding in options #10

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

carymrobbins
Copy link
Contributor

Happy to see my previous PR (#9) get merged so quickly!

Here's another one which adds SumEncoding to the options with TaggedObject support.

@carymrobbins
Copy link
Contributor Author

Hmm actually, don't merge this just yet, seems there are some edge cases where this doesn't quite work.

@carymrobbins carymrobbins changed the title Add sum encoding in options [DO NOT MERGE] Add sum encoding in options Mar 28, 2019
@carymrobbins carymrobbins changed the title [DO NOT MERGE] Add sum encoding in options Add sum encoding in options Mar 30, 2019
@carymrobbins
Copy link
Contributor Author

Ok, all's good. Was an issue with OverloadedStrings. Should be good to review/merge now.

@ali-abrar ali-abrar requested a review from cgibbard August 26, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants