Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add withDbConnString #28

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add withDbConnString #28

wants to merge 1 commit into from

Conversation

Ericson2314
Copy link
Member

In prod, we don't want to use gargoyle and do want to use a setting from
a committed config as opposed to an uncommitted file on the db path.

CC @danbornside

@Ericson2314 Ericson2314 requested a review from ali-abrar August 27, 2019 21:19
In prod, we don't want to use gargoyle and do want to use a setting from
a committed config as opposed to an uncommitted file on the db path.
@3noch
Copy link
Collaborator

3noch commented Jan 14, 2020

@Ericson2314 What do you say we close this in favor of #37. With that addition we have the ability to write withDbConnString trivially as (ish)

withDbConnString str f = case str of
  Left bytestring -> f =<< openDb bytestring
  Right filepath -> withDbPath filepath f

@3noch 3noch mentioned this pull request Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants