Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling with FFmpeg 7 #10487

Merged
merged 2 commits into from
Apr 6, 2024
Merged

Conversation

tytan652
Copy link
Collaborator

@tytan652 tytan652 commented Apr 6, 2024

Description

Fix errors introduced by building OBS Studio with FFmpeg 7.

Motivation and Context

FFmpeg 7 is out, and Arch Linux will not wait for us…

And since the errors looked easy to fix, so I made the PR.

How Has This Been Tested?

Not tested, I'll maybe try to on my side (at least the v4l2 path)…

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652 tytan652 changed the title Fix building with FFmpeg 7 Fix compiling with FFmpeg 7 Apr 6, 2024
FFmpeg 7 header states that avcodec_close should not be used since
avcodev_free_context already close the context.
@WizardCM WizardCM added Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality labels Apr 6, 2024
@Lain-B Lain-B merged commit 7d45011 into obsproject:master Apr 6, 2024
14 checks passed
@tytan652 tytan652 deleted the ffmpeg_7_mess branch April 7, 2024 00:06
@RytoEX RytoEX added this to the OBS Studio (Next Version) milestone Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants