Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-aux: Add usbmuxd socket in Flatpak #10563

Closed
wants to merge 1 commit into from

Conversation

aramg
Copy link

@aramg aramg commented Apr 17, 2024

Description

Makes usbmuxd socket available in the Flatpak sandbox.

Motivation and Context

Plugins may use usbmuxd to communicate with iOS devices via USB. Currently this is not working with the Flatpak variant due to sandboxing. This change makes it possible to access the usbmuxd socket. This change is based on a similar issue here.

How Has This Been Tested?

Launching OBS with this flag correctly maps the socket in the sandbox,
flatpak run --filesystem=/run/usbmuxd:ro com.obsproject.Studio

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@kkartaltepe
Copy link
Collaborator

kkartaltepe commented Apr 18, 2024

Please provide reference to your discussions with the flatpak community about exposing sockets via your extension. If this is a lacking feature of flatpaks, I'm sure they would like to be aware and may even provide you a solution that doesnt require OBS to randomly have access to usbmuxd when we don't use it.

@tytan652
Copy link
Collaborator

tytan652 commented Apr 18, 2024

If plugins use such a socket, it is up to the plugin to explain to the user how to add a hole in the sandbox.

Adding more holes in the Flatpak by default is not planned at all, but removing them progressively yes.

@aramg
Copy link
Author

aramg commented Apr 18, 2024

Thanks for the feedback. Going through a discussion with the Flatpak community and waiting on a resolution would probably be the correct path. Its just that having users start OBS with special parameters until that is resolved creates bad UX; the change seemed benign, hence the quick PR.

@aramg aramg closed this Apr 18, 2024
@aramg
Copy link
Author

aramg commented Apr 18, 2024

A relevant issue / feature-req: flatpak/flatpak#5211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants