Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Improve and update app CMake 3 metainfo file #10658

Merged
merged 1 commit into from
May 10, 2024
Merged

UI: Improve and update app CMake 3 metainfo file #10658

merged 1 commit into from
May 10, 2024

Conversation

tytan652
Copy link
Collaborator

@tytan652 tytan652 commented May 9, 2024 •
edited

Description

#9787 kept the old version of the metainfo file in the CMake 3 path

CMake 2 path have a newer version of this file.

See the following commits for metainfo change details:

Motivation and Context

Fix an issue

How Has This Been Tested?

CI will tell

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652 tytan652 added Bug Fix Non-breaking change which fixes an issue Linux Affects Linux labels May 9, 2024
@tytan652 tytan652 added this to the OBS Studio (Next Version) milestone May 9, 2024
@tytan652 tytan652 added the Enhancement Improvement to existing functionality label May 9, 2024
@tytan652 tytan652 mentioned this pull request May 9, 2024
Open
6 tasks
@tytan652 tytan652 added the Seeking Testers Build artifacts on CI label May 9, 2024
@RytoEX RytoEX self-assigned this May 9, 2024
@tytan652 tytan652 force-pushed the gbsneto/metainfo_cmake3 branch 3 times, most recently from 88e3a51 to 28c768d Compare May 9, 2024 15:49
@tytan652
UI: Improve and update app CMake 3 metainfo file
28c768d 
CMake 2 path have a newer version of this file.

See the following commits for metainfo change details:
- 853ae5e
- 904fe87
- 0cc6068
RytoEX
RytoEX approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @PatTheMav ?

@RytoEX RytoEX merged commit 9282231 into obsproject:master May 10, 2024
14 checks passed
@tytan652 tytan652 deleted the gbsneto/metainfo_cmake3 branch May 10, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RytoEX RytoEX RytoEX approved these changes

Assignees

@RytoEX RytoEX

Labels
Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality Linux Affects Linux Seeking Testers Build artifacts on CI
Projects
None yet
Milestone
OBS Studio 30.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tytan652 @RytoEX