Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: Add VSCode working dir to .gitignore #2147

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

JohannMG
Copy link
Contributor

Ignores additions and changes to any configurations in VSCode.

Description

Adds .vscode/*to the .gitignore file.

Motivation and Context

Myself and other users don't want to see this in staging because they should never be committed.

How Has This Been Tested?

Files in .vscode/ no longer populate git staging.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.

@WizardCM
Copy link
Member

This could probably just be vscode/ instead of vscode/*

I personally approve of this change as I use VS Code to browse the repo due to its superior search.

Ignores additions and changes to any configurations in VSCode.

$sqaushme remove wildcard
@JohannMG
Copy link
Contributor Author

@WizardCM true; updated.

@RytoEX RytoEX added the Code Cleanup Non-breaking change which makes code smaller or more readable label Oct 27, 2019
@jp9000 jp9000 merged commit 05656e5 into obsproject:master Oct 28, 2019
@JohannMG JohannMG deleted the vscode-ignore branch October 28, 2019 20:52
@obsproject obsproject deleted a comment from Oneway34-NN Oct 30, 2019
jp9000 added a commit that referenced this pull request Dec 5, 2019
git: Add VSCode working dir to .gitignore
jp9000 added a commit that referenced this pull request Dec 5, 2019
git: Add VSCode working dir to .gitignore
jp9000 added a commit that referenced this pull request Dec 6, 2019
git: Add VSCode working dir to .gitignore
jp9000 added a commit that referenced this pull request Dec 6, 2019
git: Add VSCode working dir to .gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Non-breaking change which makes code smaller or more readable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants