Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aja: Fix format-security warning which lead to a build error on some Linux distributions #5766

Merged
merged 1 commit into from
Jan 11, 2022
Merged

aja: Fix format-security warning which lead to a build error on some Linux distributions #5766

merged 1 commit into from
Jan 11, 2022

Conversation

tytan652
Copy link
Collaborator

@tytan652 tytan652 commented Jan 9, 2022 •
edited
Loading

Description

Issue introduced by f09137a.

On some Linux distributions -Werror=format-security is set when building package keeping OBS Studio from being built with AJA plugins.

Motivation and Context

Allow OBS Studio to be build with -Werror=format-security set. Which is the case on ArchLinux build system.

How Has This Been Tested?

Build OBS Studio with makepkg.

  • On master it would emit an error.
  • On this branch it builds.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652
aja: Fix format-security warning
5e40db7 
On some Linux distributions -Werror=format-security is set when
building package keeping OBS Studio from being built with AJA
plugins.
@tytan652 tytan652 changed the title aja: Fix format-security warning which lead to a build error on some Linux distribution aja: Fix format-security warning which lead to a build error on some Linux distributions Jan 9, 2022
@WizardCM WizardCM added Bug Fix Non-breaking change which fixes an issue Linux Affects Linux labels Jan 9, 2022
@Gol-D-Ace
Copy link
Member

Also needed under Ubuntu from what I have seen by trying to build the PPA.
PR appears to fix the mentioned issue.

@WizardCM WizardCM merged commit 9d02ca0 into obsproject:master Jan 11, 2022
@tytan652 tytan652 deleted the fix_format-security branch January 11, 2022 09:50
@RytoEX RytoEX added this to the OBS Studio 27.2 milestone Jan 12, 2022
@RytoEX RytoEX added this to PRs Pending Review in OBS Studio 27.2 via automation Jan 12, 2022
@RytoEX RytoEX moved this from PRs Pending Review to Completed in OBS Studio 27.2 Jan 12, 2022
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 18, 2022
@tytan652
Enable format-security errors
a8c404c 
Some Linux package build system enables it.

obsproject#5766
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 18, 2022
@tytan652
Enable format-security errors
47b5721 
Some Linux package build system enables it.

obsproject#5766
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 18, 2022
@tytan652
Enable format-security errors
1e56718 
Some Linux package build system enables it.

obsproject#5766
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 18, 2022
@tytan652
Treat warnings as errors on Clang and GNU GCC
d441c95 
Deprecation warnings are not treated as errors.

-Wformat-securityis enabled, some Linux packages build system have it
enabled.
obsproject#5766
@tytan652 tytan652 mentioned this pull request Jul 18, 2022
Merged
6 tasks
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 18, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GNU GCC
e31ecaf 
Deprecation warnings are not treated as errors.

-Wformat-securityis enabled, some Linux packages build system have it
enabled.
obsproject#5766
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 19, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GNU GCC
4dc2723 
Deprecation warnings are not treated as errors.

-Wformat-securityis enabled, some Linux packages build system have it
enabled.
obsproject#5766
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 19, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GNU GCC
d8fe07a 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 19, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
166f9dc 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 19, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
bca9a7f 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 19, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
e031360 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 21, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
28e252c 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 21, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
8150dfa 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

Also ensure that null conversion warning are enabled (C++ only for GCC)
because its enablement by default can depend on the CMake generator.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 21, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
c4e8a1a 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

Also ensure that null conversion warning are enabled (C++ only for GCC)
because its enablement by default can depend on the CMake generator.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 21, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
6fa05e8 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

Also ensure that null conversion warning are enabled (C++ only for GCC)
because its enablement by default can depend on the CMake generator.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 22, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
d3fee02 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

Also ensure that null conversion warning are enabled (C++ only for GCC)
because its enablement by default can depend on the CMake generator.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 23, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
2fa0fbb 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

Also ensure that null conversion warning are enabled (C++ only for GCC)
because its enablement by default can depend on the CMake generator.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 24, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
fbe9585 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

Also ensure that null conversion warning are enabled (C++ only for GCC)
because its enablement by default can depend on the CMake generator.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 24, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
fb83a3d 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

Also ensure that null conversion warning are enabled (C++ only for GCC)
because its enablement by default can depend on the CMake generator.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jul 24, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
d77169b 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

Also ensure that null conversion warning are enabled (C++ only for GCC)
because its enablement by default can depend on the CMake generator.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Aug 27, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
9a8a502 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Sep 1, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
3f6b1d6 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wno-error=deprecated-declarations is added on Linux/FreeBSD for release
builds to help packager.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Sep 19, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
b45de9d 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wno-error=deprecated-declarations is added on Linux/FreeBSD for release
builds to help packager.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Oct 2, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
39ea8bc 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wno-error=deprecated-declarations is added on Linux/FreeBSD for release
builds to help packager.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Oct 18, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
0dad55e 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wno-error=deprecated-declarations is added on Linux/FreeBSD for release
builds to help packager.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Oct 21, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
5b1ae62 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wno-error=deprecated-declarations is added on Linux/FreeBSD for release
builds to help packager.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Oct 25, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
f3e10c0 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wno-error=deprecated-declarations is added on Linux/FreeBSD for release
builds to help packager.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Oct 25, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
4cb1824 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wno-error=deprecated-declarations is added on Linux/FreeBSD for release
builds to help packager.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Oct 26, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
4f12de8 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wno-error=deprecated-declarations is added on Linux/FreeBSD for release
builds to help packager.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Oct 31, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
1cc5da1 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wno-error=deprecated-declarations is added on Linux/FreeBSD for release
builds to help packager.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Nov 5, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
28e5c57 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wno-error=deprecated-declarations is added on Linux/FreeBSD for release
builds to help packager.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Nov 5, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
23b5e3f 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Nov 5, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
1167483 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Nov 11, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
75d69d8 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wswitch is enabled but it is keep as a warning. It was already enabled
with Clang.

If Clang has -Wshorten-64-to-32 enabled, keep it as warnings.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Nov 11, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
2d0eeef 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wswitch is enabled but it is keep as a warning. It was already enabled
with Clang.

If Clang has -Wshorten-64-to-32 enabled, keep it as warnings.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Nov 12, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
f08f26a 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wswitch is enabled but it is keep as a warning. It was already enabled
with Clang.

If Clang has -Wshorten-64-to-32 enabled, keep it as warnings.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Nov 18, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
bcc3e42 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wswitch is enabled but it is keep as a warning. It was already enabled
with Clang.

If Clang has -Wshorten-64-to-32 enabled, keep it as warnings.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Nov 18, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
e9d6313 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wswitch is enabled but it is keep as a warning. It was already enabled
with Clang.

If Clang has -Wshorten-64-to-32 enabled, keep it as warnings.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Nov 18, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
0218a4e 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wswitch is enabled but it is keep as a warning. It was already enabled
with Clang.

If Clang has -Wshorten-64-to-32 enabled, keep it as warnings.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Nov 20, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
45ab244 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wswitch is enabled but it is keep as a warning. It was already enabled
with Clang.

If Clang has -Wshorten-64-to-32 enabled, keep it as warnings.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Nov 22, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
d7ad556 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wswitch is enabled but it is keep as a warning. It was already enabled
with Clang.

If Clang has -Wshorten-64-to-32 enabled, keep it as warnings.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Dec 10, 2022
@tytan652
cmake: Treat warnings as errors on Clang and GCC
cd289d0 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wswitch is enabled but it is keep as a warning. It was already enabled
with Clang.

If Clang has -Wshorten-64-to-32 enabled, keep it as warnings.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jan 7, 2023
@tytan652
cmake: Treat warnings as errors on Clang and GCC
c7425c5 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wswitch is enabled but it is keep as a warning. It was already enabled
with Clang.

If Clang has -Wshorten-64-to-32 enabled, keep it as warnings.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jan 13, 2023
@tytan652
cmake: Treat warnings as errors on Clang and GCC
c07d0c5 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wswitch is enabled but it is keep as a warning. It was already enabled
with Clang.

If Clang has -Wshorten-64-to-32 enabled, keep it as warnings.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jan 15, 2023
@tytan652
cmake: Treat warnings as errors on Clang and GCC
95032db 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wswitch is enabled but it is keep as a warning. It was already enabled
with Clang.

If Clang has -Wshorten-64-to-32 enabled, keep it as warnings.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jan 18, 2023
@tytan652
cmake: Treat warnings as errors on Clang and GCC
4771d67 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wswitch is enabled but it is kept as a warning. It was already enabled
with Clang.

If Clang has -Wshorten-64-to-32 enabled, keep it as warnings.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jan 18, 2023
@tytan652
cmake: Treat warnings as errors on Clang and GCC
646c2d2 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wswitch is enabled but it is kept as a warning. It was already enabled
with Clang.

If Clang has -Wshorten-64-to-32 enabled, keep it as warnings.
tytan652 added a commit to tytan652/obs-studio that referenced this pull request Jan 19, 2023
@tytan652
cmake: Treat warnings as errors on Clang and GCC
d4ce686 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wswitch is enabled but it is kept as a warning. It was already enabled
with Clang.

If Clang has -Wshorten-64-to-32 enabled, keep it as warnings.
RytoEX pushed a commit to tytan652/obs-studio that referenced this pull request Jan 19, 2023
@tytan652 @RytoEX
cmake: Treat warnings as errors on Clang and GCC
8eb174d 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
obsproject#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wswitch is enabled but it is kept as a warning. It was already enabled
with Clang.

If Clang has -Wshorten-64-to-32 enabled, keep it as warnings.
RytoEX pushed a commit that referenced this pull request Jan 19, 2023
@tytan652 @RytoEX
cmake: Treat warnings as errors on Clang and GCC
189c693 
-Wformat-security is enabled, some Linux packages build system have it
enabled.
#5766

-Wunused-parameter is enabled too.

Also ensure that null conversion (C++ only for GCC) is enabled because its
enablement by default can depend on the CMake generator.

-Wswitch is enabled but it is kept as a warning. It was already enabled
with Clang.

If Clang has -Wshorten-64-to-32 enabled, keep it as warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Fix Non-breaking change which fixes an issue Linux Affects Linux
Projects
OBS Studio 27.2
  
Completed
OBS Studio 27.2 Release Bug Tracker
Archived in project
Milestone
OBS Studio 27.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tytan652 @Gol-D-Ace @RytoEX @WizardCM