-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CMake Warning and tweak Linux install_headers #6768
Conversation
Fix a warning thrown by CMake.
Even without it, we still need to run the following command for other files: `cmake --install . --component obs_libraries`
What's the impact on Windows? Does it create stray header files in the runDir? |
We might have to run it on CI to find out, as I think the issue resolved by #6719 was CI only. Adding Seeking Testers and re-running CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @PatTheMav ?
I haven't tested the changes locally, but looks fine to me. |
Description
Fix this warning:
And add EXCLUDE_FROM_ALL to Linux install_headers, because even without it we still need to run
cmake --install . --component obs_libraries
Motivation and Context
Fix a warning, and tweak something.
How Has This Been Tested?
Try to build a
-git
package (with my own PKGBUILD) which usecmake --install . --component obs_libraries
, header are there.And Cmake no longer throw the warning.
Types of changes
Checklist: