linux-pipewire: Close sessions as we are done with them #7470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleixpol
force-pushed
the
work/close-when-done
branch
from
0d61cd7
to
dc24c77
Compare
tytan652
added
Bug Fix
|
Commit prefix should not have |
aleixpol
changed the title
aleixpol
force-pushed
the
work/close-when-done
branch
from
dc24c77
to
815c47c
Compare
Addressed, thanks! |
GeorgesStavracas
requested changes
Sep 26, 2022
aleixpol
force-pushed
the
work/close-when-done
branch
from
815c47c
to
a7a285e
Compare
|
Addressed both and tested them to work. |
aleixpol
force-pushed
the
work/close-when-done
branch
from
a7a285e
to
88b0ed8
Compare
GeorgesStavracas
approved these changes
Sep 26, 2022
This way the stream can be cleaned up. Otherwise, we closed them all when OBS closes which works but is not entirely correct.
aleixpol
force-pushed
the
work/close-when-done
branch
from
88b0ed8
to
5db5d7f
Compare
|
This should be picked to the release/28.0 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This way the stream can be cleaned up. Otherwise, we closed them all when OBS closes which works but is not entirely correct.
Motivation and Context
On Plasma we show an element for each button and it would infinitely grow as we interact with OBS.
How Has This Been Tested?
I've been testing this against our system and confirmed that Close is called as we replace the session_handle so the system can properly clean up the UI.
Types of changes
Checklist: