Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-pipewire: Check format availablity against DRM only for dmabufs #7986

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

columbarius
Copy link
Contributor

Description

Fixes pipewire-screencast when using a software renderer

Motivation and Context

Whe using a software renderer there will be no formats available for using with dmabufs. We should only consider those formats wrt. to modifiers and as such move this check after adding general support for that format.

Fixes #7985

How Has This Been Tested?

Run obs with LIBGL_ALWAYS_SOFTWARE=true

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Whe using a software renderer there will be no formats available for
using with dmabufs. We should only consider those formats wrt. to
modifiers and as such move this check after adding general support for
that format.

fixes obsproject#7985
@tytan652 tytan652 added Bug Fix Non-breaking change which fixes an issue Linux Affects Linux labels Dec 30, 2022
Copy link
Collaborator

@kkartaltepe kkartaltepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on my machine, thanks.

@jp9000 jp9000 merged commit d8b7906 into obsproject:master Jan 7, 2023
@RytoEX RytoEX added this to the OBS Studio 29.0 milestone Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Linux Affects Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipewire format negotiation can fail to fallback to shared memory
5 participants