Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux-pipewire: Clear cursor texture on empty bitmap #8467

Merged
merged 1 commit into from
Mar 14, 2023
Merged

linux-pipewire: Clear cursor texture on empty bitmap #8467

merged 1 commit into from
Mar 14, 2023

Conversation

rmader
Copy link
Contributor

@rmader rmader commented Mar 14, 2023

If we receive an empty cursor bitmap - one without valid size - we should hide the cursor. Do so by clearing the texture.

This fixes visible cursors when recording various games with Wayland compositors.

Closes #4895

How Has This Been Tested?

Locally tested, asking other people to test as well.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@rmader rmader mentioned this pull request Mar 14, 2023
Closed
tytan652
tytan652 suggested changes Mar 14, 2023
View reviewed changes
plugins/enc-amf Outdated Show resolved Hide resolved
@tytan652 tytan652 added the Linux Affects Linux label Mar 14, 2023
GeorgesStavracas
GeorgesStavracas approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@GeorgesStavracas GeorgesStavracas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding the Closes https://github.com/obsproject/obs-studio/issues/4895 to the commit message too?

The code LGTM. Thank you very much. This bug has been pestering OBS for 2 years.

@rmader
Copy link
Contributor Author

rmader commented Mar 14, 2023

Should we mark this for backporting somehow? Or is that done automatically?

@GeorgesStavracas
Copy link
Member

Should we mark this for backporting somehow? Or is that done automatically?

We'll think that separatedly, don't worry

@tytan652 tytan652 added the Bug Fix Non-breaking change which fixes an issue label Mar 14, 2023
@rmader rmader force-pushed the fix-hidden-cursors branch 2 times, most recently from 0a0e062 to 4ca5bd4 Compare March 14, 2023 13:07
@rmader
linux-pipewire: Clear cursor texture on empty bitmap
573302b 
If we receive an empty cursor bitmap - one without valid size - we
should hide the cursor. Do so by clearing the texture.

This fixes visible cursors when recording various games with Wayland
compositors.

Closes obsproject#4895
@GeorgesStavracas GeorgesStavracas merged commit 0a36dc9 into obsproject:master Mar 14, 2023
@RytoEX RytoEX added this to the OBS Studio 29.1 milestone Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tytan652 tytan652 tytan652 requested changes

@GeorgesStavracas GeorgesStavracas GeorgesStavracas approved these changes

Assignees
No one assigned
Labels
Bug Fix Non-breaking change which fixes an issue Linux Affects Linux
Projects
None yet
Milestone
OBS Studio 29.1
Development

Successfully merging this pull request may close these issues.

Cursor doesn't properly disappear with Pipewire capture
4 participants
@rmader @GeorgesStavracas @tytan652 @RytoEX