New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
obs-ffmpeg: Enable multi-track audio support for mpegts #9028
Conversation
We've reviewed this and the question that was raised is if this change prevents unselecting all audio tracks. Recently OBS started enforcing that at least one audio track is selected for recordings, and this behaviour should be reflected here too. |
I'm really not sure. |
@GeorgesStavracas i checked current behaviour with recording and there's a warning indeed when no track is selected. I see now what you meant. I've added that too in case some clueless user uncheck all audio tracks. |
434736c
to
73dd9f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should not be coded as a MPEG TS only feature when it comes to naming, since in the future another container/protocol might do the same thing.
The commit 73dd9f8 has a too long line, 80 characters, where it's limit is 72.
|
yeah, I had already thought about it. This is code I wrote a long while ago. But given there's a new rtmp spec which is still being worked on, I did plan on updating the code to be protocol neutral. I wanted the PR out sooner than later due to SRT PlugFest. |
thanks, i'll fix that |
i'm gonna also use dedicated stream tracks instead of the recording tracks since some people might want to change encoders for streaming and recording. |
635147d
to
458fe48
Compare
Update
|
I've been using this patch in one form or another since July 2022. I can confirm that it continues to work on OBS v30. |
Well, I first have to address the comments, which I didn't because ... life. |
Would love to see this in the next version please. would help alot |
This adds support for multiple audio tracks for the new mpegts output. Signed-off-by: pkv <pkv@obsproject.com>
This enables audio multi-track support in UI for mpegts streams (srt, rist ...). The UI changes were coded though to allow re-use by other protocols. Signed-off-by: pkv <pkv@obsproject.com>
Was so long ago, I had forgotten that I had actually addressed the comments. Will request that it moves forward. |
Rebased to current master. |
Description
This adds support for multi-track audio for mpegts outputs (srt or rist).
Also modifies UI.
For mpegts compatible protocols, this changes radio buttons into checkboxes for the audio track selection in the Streaming output (only in Advanced output).
Motivation and Context
YouTube has added support for SRT ingest and allowed broadcast engineers to test it during the 2023 SRT Plugfest.
I was told during the zoom introduction that multi-track support is being worked on by YouTube (public discussion,
there was no NDA).
I had this code around for a while, so it seems it's the right time to add it to obs.
Maybe multi-track will be supported also by RTMP (who knows) and the code would use the UI parts of this PR.
How Has This Been Tested?
Tested against several services during 2023 SRT Plugfest.
Works as expected. One can play any track.
Types of changes
Checklist: