Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win-capture: Replace CS:GO references with Counter-Strike 2 #9678

Closed
wants to merge 1 commit into from

Conversation

prgmitchell
Copy link
Contributor

Description

This replaces the compatibility message for CS:GO with one for Counter-Strike 2. As CS:GO servers are no longer online, I figured it made more sense to replace this rather than add another.

image

Motivation and Context

CS:GO is no more, and someone mentioned this in the community discord server.

How Has This Been Tested?

Replaced the compatibility json, loaded up CS2, made sure the message appeared as seen in the screenshot above.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Copy link
Member

@derrod derrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to increment the version in package.json.

@prgmitchell
Copy link
Contributor Author

prgmitchell commented Oct 8, 2023

Don't forget to increment the version in package.json.

Is this expected to be a separate commit or should I squash it?

EDIT: Dumb question, I will squash it.

Replace compatibility message information for CS:GO with
Counter-Strike 2.
@TianQiBuTian
Copy link
Contributor

Suggest retaining CSGO.
Reason: Due to the immature community plugins in CS2, many community servers remain in CSGO, and players also choose to downgrade to CSGO through Steam's branch to play on CSGO's community servers.

See:
alliedmodders/source2mod#2

(And I have already added CS2 in the #8617)

@prgmitchell
Copy link
Contributor Author

Suggest retaining CSGO. Reason: Due to the immature community plugins in CS2, many community servers remain in CSGO, and players also choose to downgrade to CSGO through Steam's branch to play on CSGO's community servers.

See: alliedmodders/source2mod#2

(And I have already added CS2 in the #8617)

I did not realize you had an open PR, I had not seen one recently and didn't consider someone had opened one that long ago considering CS2 just officially released. I think your PR covers this, I will close this once yours is merged as it sounds like it is good to go from the comments on your PR.

@prgmitchell
Copy link
Contributor Author

Closing as #8617 has been merged

@prgmitchell prgmitchell closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants