rtmp-services: Add LiveSpace #9734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RytoEX
added
the
Services
Fenrirthviti
approved these changes
Feb 1, 2024
|
This PR has merge conflicts, so it cannot be merged as-is. Unfortunately, this PR also has maintainer edits disabled, so I cannot fix them myself. |
|
Thanks - I can fix it but can't commit here, nor know how to make it fixable for you - guess I have to resync my repo and do a new PR; sucks, as hope to salvage this one, as been months. |
You just need to check this box at the right side of the screen: |
Marks old AVFoundation capture source as deprecated.
QuickSync requires oneVPL, which is unable to find its libraries in the Flatpak, resulting in MFX_ERR_NOT_FOUND and the encoders not working. The libraries are present in the install prefix (/app/lib), which is currently not automatically added to the search paths, see the issue intel/libvpl#119 for details. For now, work around the issue by setting ONEVPL_SEARCH_PATH explicitly.
If a user sets both AdaptiveMiniGOP=true and EnablePreAnalysis=true in the AMF/FFmpeg options field, AMF will adaptively insert B-pictures, and no longer uses the fixed B pattern. For a fixed B-frames pattern, it is expected that increasing B-frames can cause a quality drop for certain content such as with high motion. AdaptiveMiniGOP is recommended when using B-frames to improve the quality in such cases. AdaptiveMiniGOP is dependent on PreAnalysis which means that trying to enable it without having PreAnalysis turned ON will have no negative effect (AdaptiveMiniGOP won't be enabled).
Fixes several possible crash issues that might occur on Intel-based Macs and older macOS versions: On modern macOS versions (13+) allocated memory is zero-allocated by default which makes NULL pointer checks work correctly after allocation. On older macOS versions this is not the case, so the OBSAVCaptureInfo struct needs to be zero-allocated to ensure the guards in the tick and render functions bail out correctly. On Intel-based Macs and/or older macOS versions passing a reference to the OBSAVCapture instance inside the OBSAVCapture struct can lead to a crash because of a possible circular reference that cannot be resolved at runtime. Passing only a reference of the OBSAVCapture to libobs and incrementing the retain count at source creation (decrementing in when the source is destroyed) avoids this issue entirely.
(Lain note: Splitting parent commit. This was probably unintentionally not taken into account in the origin crop_to_bounds PR.)
Fixes future deprecation warnings
In order to support crop_to_bounds, deprecates: obs_sceneitem_set_info obs_sceneitem_get_info In favor of: obs_sceneitem_set_info2 obs_sceneitem_get_info2
Fixes a versioning issue
They contain a more recent commit with a fix for a flatpak-builder regression.
This is what Flathub uses now. It's an implementation detail that will eventually be hidden away in a Flathub-specific publish action. But for now, we still publish directly, and we have to adapt.
The beginInsertRows/endInsertRows calls seem to signal that the rowCount has changed, and that views should adjust accordingly. The isProcessing boolean changes the returned value of RemuxQueueModel::rowCount, which seems to cause the empty row in the table model to disappear permanently. I still don't know why it used to work this way and no longer does.
Notable changes: * deps.ffmpeg: Force classic linker for AppleClang 15.0.0+ * CI: Update macOS jobs to use macOS 14 runners * deps.ffmpeg: Enable runtime CPU detection for AOM to fix ARM64 crashes * deps.ffmpeg: Update zlib to 1.3.1 * deps.ffmpeg: Update aom to 3.8.1 * deps.ffmpeg: Update mbedTLS to 3.4.1 * deps.qt: Update Qt6 to 6.6.2 for Windows * deps.qt: Update Qt6 to 6.6.2 for macOS * deps.qt: Restore native dialogs on macOS
Also add AppStream validation to Build Project workflow
Some devices will report different framerate ranges for formats that are identical apart from color primaries. Without taking these into account, only framerates for one color primary variant would be used to populate the framerate dropdown in the property view of the camera source. Checking for a difference in color primaries when iterating over all available formats for a device thus requires checking for this variation and adding the additional frame rate range as well.
When a prior scheduled nightly run is detected with the identical commit hash, then the entire language file check should be skipped. This adds the missing condition to skip the check for changed files removing the unnecessary warning contained in the workflow results.
Python 3.11 and later support a system-wide configuration setting that marks the system packages as "externally managed" (e.g. to force using apt packages instead of pip packages). This breaks installation of the modules necessary to run the validators, so use a virtual environment instead.
Notable changes: * deps.ffmpeg: Revert libsrt to 1.5.2 to avoid a crash
This fixes a bug where the source context bar wouldn't update when a scene item is deleted.
This removes the LoadOutputSettings() called in SaveStream1Settings. It caused a bug when trying to save Output settings when both Stream and Output settings have been changed but the changes have not been applied by hitting the 'Apply' button in Settings. Signed-off-by: pkv <pkv@obsproject.com>
This toggles audio multi track display in Output settings when: 1. When there is a signal that a stream service is changed to a non custom one. Indeed multi-track audio is only available with Custom service and only with SRT or RIST protocols. 2. When a Custom service is picked, and SRT or RIST are detected in the server URL. 3. When Stream settings are saved when one hits Apply. This is in addition to the toggling done when loading Stream Settings. Signed-off-by: pkv <pkv@obsproject.com>
|
Can I do that on existing PR, as not obvious how here, or maybe can convert to draft and try again? Or best to start over and redo a new PR using latest merged changes I saw you made today? Apologies for challenges. |
You apparently cannot enable maintainer edits here because of a quirk with how GitHub handles PRs made by individuals from an organization repo: You either need to fix this PR up yourself, or open a new one that is fixed. I would recommend not opening a PR from an organization repo to avoid the problem above. I would also recommend that you:
|
|
Closing this PR as LiveSpace shut down on May 1, 2024. https://about.live.space/post/thank-you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added LiveSpace to rtmp-services list
Motivation and Context
Adding our LiveSpace service for user convenience
How Has This Been Tested?
Tested locally
Types of changes
Checklist: