This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
Fixed Test Coverage PR #227 #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlafSzmidt
requested review from
Spycho,
ramonfmir,
danalex97 and
CelineBoudier
CelineBoudier
suggested changes
Sep 5, 2017
| def kill(self): | ||
| self.binder.killed = True | ||
|
|
||
| localWorkerManger = LocalWorkerManager("") |
There was a problem hiding this comment.
please write Manager instead of Manger :)
Closed
|
Thanks, but I think that could only be one commit as you fixed a typo introduced by the previous commit |
(cherry picked from commit ded992f) More tests for worker manager. (cherry picked from commit f4441b3) Turn Manager fully tested. Initial fog of war tests. (cherry picked from commit edfe2ae) PEP8 fixes + spelling mistakes Further fixes for the pull request. (cherry picked from commit bf92d07) "Manager" typo changed.
OlafSzmidt
force-pushed
the
test_coverage_fixed
branch
from
d004529 to
f1796a1
Compare
CelineBoudier
approved these changes
Sep 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After yesterday's (04/09/2017) issues with rebasing and merging my pull request became obsolete and I was unable to get it back into a working state.
Instead I forked out from master again and cherry picked relevant commits. They're also squashed and all changes are applied as suggested in #227.
I will now close #227.