This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
Refactoring and PEP8 fixes. #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CelineBoudier
suggested changes
Sep 18, 2017
| @@ -36,6 +36,7 @@ def apply_fog_of_war(world_map, avatar_wrapper): | |||
|
|
|||
|
|
|||
| def should_partially_fog(no_fog_distance, partial_fog_distance, x_dist, y_dist): | |||
| # TODO: partial_fog_distance implemented in this method somehow. | |||
There was a problem hiding this comment.
we tend not to commit todo comments
There was a problem hiding this comment.
I'd rather we open an issue
| @@ -61,15 +62,16 @@ def _register_action(self, avatar): | |||
| with state_provider as game_state: | |||
| avatar.action.register(game_state.world_map) | |||
|
|
|||
| def _update_environment(self, game_state): | |||
| @staticmethod | |||
| def _update_environment(game_state): | |||
| num_avatars = len(game_state.avatar_manager.active_avatars) | |||
| game_state.world_map.reconstruct_interactive_state(num_avatars) | |||
|
|
|||
| def _mark_complete(self): | |||
| pass | |||
| # TODO: Make completion request work. For now, we assume games don't finish. | |||
|
@CelineBoudier Do you want me to recommit the files without the comments, or leave them with the issues? |
|
@OlafSzmidt please recommit without the comments :) thanks |
TODO comments removed.
OlafSzmidt
force-pushed
the
refactor
branch
from
4479496 to
865c212
Compare
CelineBoudier
suggested changes
Sep 18, 2017
| #from world_state import WorldState | ||
| #requests.post(self._completion_url, json=world_state.get_update()) | ||
| # from world_state import WorldState | ||
| # requests.post(self._completion_url, json=world_state.get_update()) |
There was a problem hiding this comment.
we don't commit commented code either :)
aimmo-game/simulation/world_map.py
Outdated
| @@ -208,7 +209,7 @@ def _update_map(self, num_avatars): | |||
| self._add_pickups(num_avatars) | |||
|
|
|||
| def _expand(self, num_avatars): | |||
| #LOGGER.info('Expanding map') | |||
| # LOGGER.info('Expanding map') | |||
CelineBoudier
approved these changes
Sep 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code PEP8 fixes as well as refactoring when I was reading the codebase trying to get hang of it ;)