This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 71
Minimum Product: Partial Fog removal #261
Merged
CelineBoudier
merged 1 commit into
ocadotechnology:master
from
OlafSzmidt:partially_fogged_removal
Oct 4, 2017
Merged
Minimum Product: Partial Fog removal #261
CelineBoudier
merged 1 commit into
ocadotechnology:master
from
OlafSzmidt:partially_fogged_removal
Oct 4, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlafSzmidt
requested review from
mrniket,
danalex97,
chris-leach,
OliverCartz and
CelineBoudier
September 28, 2017 15:46
OlafSzmidt
force-pushed
the
partially_fogged_removal
branch
from
September 29, 2017 13:20
0b5f992
to
5a45e01
Compare
mrniket
reviewed
Oct 3, 2017
@@ -151,6 +151,7 @@ class TestService(TestCase): | |||
(GameCreatorProxy(self), 1), # pair of proxy and turns | |||
(GameProxy(self), 1) | |||
], False) # set True for kubernates | |||
error: [Errno 98] Address already in use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this line for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhhhhh. Accidentally pasted something in 👍
CelineBoudier
previously requested changes
Oct 3, 2017
@@ -151,6 +151,7 @@ class TestService(TestCase): | |||
(GameCreatorProxy(self), 1), # pair of proxy and turns | |||
(GameProxy(self), 1) | |||
], False) # set True for kubernates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kubernetes 😂
OlafSzmidt
force-pushed
the
partially_fogged_removal
branch
from
October 3, 2017 17:03
dbd08d3
to
939c20b
Compare
…#240 More instances of partially_fogged removed Partially_fogged removed completely. Fixed incorrect comment + little refactoring of xrange
OlafSzmidt
force-pushed
the
partially_fogged_removal
branch
from
October 3, 2017 17:04
939c20b
to
daeef51
Compare
Rebased and squashed. Changes made too. |
mrniket
approved these changes
Oct 4, 2017
CelineBoudier
approved these changes
Oct 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.