Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter benchmarks based on tag #196

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Filter benchmarks based on tag #196

merged 2 commits into from
Dec 4, 2020

Conversation

kayceesrk
Copy link
Contributor

Remove the custom targets _macro.json and _ci.json and replace that with a generic solution. See #195.

@kayceesrk kayceesrk added the enhancement New feature or request label Dec 2, 2020
@kayceesrk
Copy link
Contributor Author

@Sudha247 please see if this is what you were looking for.

@Sudha247
Copy link
Contributor

Sudha247 commented Dec 3, 2020

Thanks for this solution @kayceesrk! This is what I was looking for. I have only one suggestion; It might useful to remove *_filtered.json during make clean. A note on this feature (in the README perhaps) would be helpful, too. :)

Copy link
Contributor

@shakthimaan shakthimaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kayceesrk
Copy link
Contributor Author

I have only one suggestion; It might useful to remove *_filtered.json during make clean. A note on this feature (in the README perhaps) would be helpful, too. :)

Done.

@kayceesrk kayceesrk merged commit ca5cda9 into master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants