Skip to content

Add support for OCaml 5.00 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2022
Merged

Conversation

kit-ty-kate
Copy link
Contributor

No description provided.

@pmetzger pmetzger merged commit 25aa6bc into ocaml-community:master Feb 19, 2022
@kit-ty-kate
Copy link
Contributor Author

Thanks! If you have the time, could you make a release if possible?

@pmetzger
Copy link
Member

@kit-ty-kate Given that you're responsible for keeping these sorts of things working as OCaml releases come out, would you prefer to simply have access to the OCaml Community repositories yourself?

@@ -10,7 +10,7 @@ build: [
["dune" "runtest" "-p" name "-j" jobs] {with-test}
]
depends: [
"ocaml" {>= "4.02.3"}
"ocaml" {>= "4.03.0"}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ocaml" {>= "4.03.0"}
"ocaml" {>= "4.08.0"}

I just realized Format.stag and so on were added in OCaml 4.08 so this needs to change as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should now have access as soon as you accept it (check your email.)

@kit-ty-kate
Copy link
Contributor Author

Given that you're responsible for keeping these sorts of things working as OCaml releases come out, would you prefer to simply have access to the OCaml Community repositories yourself?

Sure, if you don’t have the time I can do it if given the rights. Though I’m already responsible for far too many things so if there is another solution it might be preferable.

@pmetzger
Copy link
Member

I think it might actually save you time by allowing you to avoid needless interactions for obvious fixes. I'll add you shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants