Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor the code #24

Merged
merged 8 commits into from
Jul 15, 2019
Merged

refactor the code #24

merged 8 commits into from
Jul 15, 2019

Conversation

kandu
Copy link
Collaborator

@kandu kandu commented Jun 26, 2019

  • refactor the code to make the internal logic more consistent
  • Zed_string.Invalid exception

@pmetzger
Copy link
Member

Are there changed tests to go along with the change in the API?

@kandu
Copy link
Collaborator Author

kandu commented Jul 15, 2019

I've made a pre-release on my personal repository and tested it on both linux and windows. All seems good. Talk is cheap, let's do something unwise again :)

@kandu
Copy link
Collaborator Author

kandu commented Jul 15, 2019

And after uucd, uucp are integrated as dependencies #16, we can do a refactoring again to improve the internal logic to support more kind of writing systems, e.g. Hangul Jamo.

@kandu kandu merged commit 28d2d9d into ocaml-community:master Jul 15, 2019
@kandu kandu deleted the refactor branch July 15, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants