wanted_column now works with wide graphemes #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Oct 31, 2019
src/zed_lines.mli
Outdated
| @@ -74,3 +74,7 @@ val replace : t -> int -> int -> t -> t | |||
| (** [replace set offset length repl] replaces the subset at offset | |||
| [offset] and length [length] by [repl] in [set]. *) | |||
|
|
|||
| val get_idx_by_width : t -> int -> int -> int | |||
| (** [get_idx_by_width set column_width] return the offset of the char at | |||
There was a problem hiding this comment.
The spec in the documentation comment looks wrong; it has only two arguments while the function takes 3
There was a problem hiding this comment.
Thank you, doc comment is fixed now.
|
Nice! The two gifs look the same to me BTW |
They are actually different, on the first gif, the cursor always fall at the end of the second line. |
|
yeah, previously, wanted_column is counted based on the number of characters. so in the first gif, it always want to jump to the 6th character of line 2, which exceed the eol. |
|
Ah, indeed I missed that |
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wanted_column now works with wide graphemes.
Instead of recording the offset, the wanted_column value records the current column_display which is based on the width of the graphemes.
Every time a user goto prev_n or next_n lines, goto bol, eol etc it now calculates the offset at the given column_width and set the result offset as the new position.
Click to expand the GIFs
before this patchafter this patch