Add the allocation pointer to the OCaml calling convention #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usuyus
force-pushed
the
oxcaml-allocptr
branch
from
f45bdfb to
41a7d0d
Compare
gretay-js
reviewed
Aug 15, 2025
| def CSR_64 : CalleeSavedRegs<(add RBX, R12, R13, R14, R15, RBP)>; | ||
|
|
||
| // R14 and R15 are used as return registers, so they aren't callee saved. | ||
| def CSR_64_OCaml_C_Call : CalleeSavedRegs<(add RBX, R12, R13, RBP)>; |
gretay-js
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
R15to the X86-64 calling conventions for OCaml. Proper threading of runtime registers forcaml_c_call'ed functions is also added.