Skip to content

[lld] check disk space before writing to disk if using mmap #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2024
Merged

[lld] check disk space before writing to disk if using mmap #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions lld/ELF/Writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
#include "Config.h"
#include "InputFiles.h"
#include "LinkerScript.h"
#include "llvm/Support/FileSystem.h"
#include "llvm/Support/Path.h"
#include "MapFile.h"
#include "OutputSections.h"
#include "Relocations.h"
Expand Down Expand Up @@ -2818,6 +2820,18 @@ template <class ELFT> void Writer<ELFT>::openFile() {
flags |= FileOutputBuffer::F_executable;
if (!config->mmapOutputFile)
flags |= FileOutputBuffer::F_no_mmap;
if (config->mmapOutputFile) {
// LLD relies on [fallocate] to mmap the output.
// In case there's no space left on the device
// it will error with SIGBUS, which is confusing
// for users
auto ErrOrSpaceInfo = sys::fs::disk_space(sys::path::parent_path(config->outputFile));
if (!ErrOrSpaceInfo)
error("Can't get remaining size on disk");
if (ErrOrSpaceInfo.get().free < fileSize)
error("failed to open " + config->outputFile + ": " +
"No Space Left on Device");
}
Expected<std::unique_ptr<FileOutputBuffer>> bufferOrErr =
FileOutputBuffer::create(config->outputFile, fileSize, flags);

Expand Down