Skip to content

Drop open related file code action #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Drop open related file code action #1520

wants to merge 2 commits into from
+5 −48

Conversation

xvw
Copy link
Collaborator

@xvw xvw commented Apr 16, 2025

@xvw xvw requested a review from voodoos April 16, 2025 14:08
@coveralls
Copy link

coveralls commented Apr 16, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 4843

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 55 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.2%) to 22.925%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ocaml-lsp-server/src/code_actions.ml 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
ocaml-lsp-server/src/document.ml 1 61.54%
lsp/src/import.ml 10 33.0%
ocaml-lsp-server/src/code_actions/action_open_related.ml 14 6.45%
lsp/src/types.ml 30 12.78%
Totals Coverage Status
Change from base Build 4841: -0.2%
Covered Lines: 5875
Relevant Lines: 25627
💛 - Coveralls

@xvw
Copy link
Collaborator Author

xvw commented Apr 16, 2025

Since (ATM), Code-Action is the only way to handle behaviour without needing for modification in any client, let's keep it for the moment!

@xvw xvw closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voodoos voodoos Awaiting requested review from voodoos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xvw @coveralls