Graphics.close_graph crashes 64-bit Windows ports #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At the moment, this implementation won't release two separate threads both blocking on |
MPR3963 incorrectly fixed in 4.01.0. Closing the graphics window will now cause calls to Graphics.wait_next_event to terminate (which was the original MPR) and calling Graphics.close_graph no longer crashes the 64-bit runtime.
|
(updated Changes file) |
|
Thanks for finding and fixing this bug! |
damiendoligez
added a commit
that referenced
this pull request
Jul 20, 2016
Graphics.close_graph crashes 64-bit Windows ports
|
Rebased and merged into trunk. |
|
No worries - could the fix go in 4.03 too? |
|
I don't think any bugfix release in planned on 4.03. |
|
Ah, fair enough! |
camlspotter
pushed a commit
to camlspotter/ocaml
that referenced
this pull request
Oct 17, 2017
Graphics.close_graph crashes 64-bit Windows ports
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Sep 21, 2022
* Rebase * ocamlformat * Disable CFG tests. * Restore ocamlcfg tests. * Prologue * Revert dataflow changes. * Revert dataflow changes. * Format * Use the dedicated flag. * Review * Review * CRs * Review * ocamlformat * Arm64 * Review * Review * Review * Review * ocamlformat * Fix review change * Debugging tweaks. * ocamlformat * Review. * ocamlformat Co-authored-by: Greta Yorsh <gyorsh@janestreet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for MPR3963 was added in b147d07 (released in 4.01.0) by @damiendoligez. As far as I can see, this fix never worked: I think it's fundamentally broken and on the 32-bit Windows ports it doesn't work and on the 64-bit Windows ports, it causes
Graphics.close_graphto bring down the runtime.I believe the original intention was that closing the graphics window (via the X button) should result in any calls to
Graphics.wait_next_eventterminating with:but this is done by causing WM_DESTROY to raise an OCaml exception - but the window handler is in a non-OCaml thread, so it cannot possibly raise OCaml exceptions?