Check for integer overflow in Bytes.extend #934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasche
reviewed
Nov 26, 2016
| @@ -128,6 +128,9 @@ Next version (4.05.0): | |||
|
|
|||
| ### Bug fixes | |||
|
|
|||
| - GPR#934: check for integer overflow in Bytes.extend | |||
| (Jeremy Yallop) | |||
There was a problem hiding this comment.
Sorting entries by MPR first, GPR second, this should go as the very last item of the category.
| let len = length s + left in | ||
| if len < 0 then invalid_arg "Bytes.extend" else | ||
| let len = len + right in | ||
| if len < 0 then invalid_arg "Bytes.extend" else |
There was a problem hiding this comment.
I find the shadowing used here not very readable. You could name the first variable len_left, or declare let (++) a b = (* check for overflow *) let c = a + b in if c < 0 then invalid_arg "Bytes.extend" else c and let len = length s ++ left ++ right.
yallop
force-pushed
the
bytes-extend-overflow
branch
from
ae0edd6 to
85c27f2
Compare
|
Thanks for the comments, @gasche. I've updated the patch. I think this may need a bit more care before merging, though, since it rejects Bytes.extend "abc" (-4) 4which was previously accepted, and had reasonable behaviour. I'll come back to this shortly. |
yallop
force-pushed
the
bytes-extend-overflow
branch
from
85c27f2 to
35209c3
Compare
yallop
force-pushed
the
bytes-extend-overflow
branch
from
35209c3 to
5de7108
Compare
|
I'm partial to patches that come with testsuite support. Merged. |
camlspotter
pushed a commit
to camlspotter/ocaml
that referenced
this pull request
Oct 17, 2017
Check for integer overflow in Bytes.extend
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Mar 21, 2023
* Add compilation flag -caml-apply-inline-fast-path * Use -caml-apply-inline-fast-path for main build and libraries * Inline fast path of caml_apply * Bind args * Refactor and apply the same transformation to Flamba 2. * Pass [ty] argument to [call_caml_apply] * Add a CR about a version of caml_applyN that has only cold path and update a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour:
With this fix: