Fix bug when installing with a system compiler (and without coreutils) #54
Conversation
AltGr
changed the title
|
After some digging, @dra27 finally got the reason why this seemed to only fail on OCamlPro's Docker image and not the other ones: differences in how coreutils' |
|
I forgot to mention that this was a regression in 1.9.5 |
| @@ -123,7 +123,7 @@ clean: | |||
| install: all | |||
| $(INSTALLDIR) "$(DESTDIR)$(prefix)$(OCAML_SITELIB)/$(NAME)" | |||
| $(INSTALLDIR) "$(DESTDIR)$(prefix)$(OCAMLFIND_BIN)" | |||
| $(INSTALLDIR) "$(DESTDIR)$(prefix)$(OCAML_CORE_STDLIB)" | |||
| test $(INSTALL_TOPFIND) -eq 0 || $(INSTALLDIR) "$(DESTDIR)$(prefix)$(OCAML_CORE_STDLIB)" | |||
There was a problem hiding this comment.
It might be a different bug that can still occure for people who install ocamlfind without opam.
With and without coreutils, install -d will set the permissions to 755. So if the user wanted to keep the permission of their installation directory the same, installing ocamlfind will change it without notice.
There was a problem hiding this comment.
I think that's worth opening in a separate issue. I'm not sure whether it should be install -d, test -d || install -d, or whether mkdir -p will do 🤷♂️
See https://discuss.ocaml.org/t/problem-installing-ocamlfind-on-latest-ocamlpro-alpine-docker-image/10147