Skip to content

Don't compute the unused list removed_items in Tools.fragmap #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2024
Merged

Don't compute the unused list removed_items in Tools.fragmap #1036

merged 1 commit into from
Jan 12, 2024

Conversation

gpetiot
Copy link
Collaborator

@gpetiot gpetiot commented Nov 10, 2023

A small optimization + cleanup found while working on the sig optimization.

Julow
Julow approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you measure any performance difference ?

Otherwise, the code looks good and is cleaner.

@Julow Julow added the no changelog This pull request does not need a changelog entry label Nov 10, 2023
@gpetiot
Copy link
Collaborator Author

gpetiot commented Nov 27, 2023

Did you measure any performance difference ?

ocaml-benchmarks doesn't show any big difference.

Rebasing this branch on landmarks shows the same: running compile on html_sigs stays between 13.5-13.7

@Julow Julow merged commit bae3714 into ocaml:master Jan 12, 2024
@gpetiot gpetiot deleted the optimize-apply_sig_map branch January 12, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julow Julow Julow approved these changes

Assignees
No one assigned
Labels
after-2.4 no changelog This pull request does not need a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gpetiot @Julow @EmileTrotignon