Fix using odoc_driver to build odoc
#1205
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quoting the docs of the Findlib library: > * Furthermore, the environment variables OCAMLPATH, OCAMLFIND_DESTDIR, > * OCAMLFIND_COMMANDS, OCAMLFIND_IGNORE_DUPS_IN, and CAMLLIB are interpreted. > * By default, the function takes > * the values found in the environment, but you can pass different values > * using the [env_*] arguments. By setting these values to empty strings > * they are no longer considered. So when we do ``` dune exec -- odoc_driver -p odoc ``` findlib finds the `odoc` library in `_build/install` in some part of the codebase, in `<opam switch>/lib/odoc` in some other parts of the code, which results in the docs for `odoc` not being built. This changes to consistently find the `<opam switch>/lib/odoc`.
|
Surely there is a better way here. I originally opened the PR with the confusion that it would take the compile time value, which was then always wrong. |
|
Closed in favour of #1229 |
|
(specifically be730cb) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoting the docs of the Findlib library:
So when we do
findlib finds the
odoclibrary in_build/installin some part of the codebase1, in<opam switch>/lib/odocin some other parts of the code, which results in the docs forodocnot being built.This changes to consistently find the
<opam switch>/lib/odoc.Footnotes
because theMissread... ↩ocamlpathof compile time was used!