Skip to content

opam: Update lower bounds on yojson #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2024
Merged

opam: Update lower bounds on yojson #1212

merged 1 commit into from
Oct 10, 2024

Conversation

Julow
Copy link
Collaborator

@Julow Julow commented Oct 10, 2024

The output format of older yojson was unstable in some cases.

@Julow
opam: Update lower bounds on yojson
3a92406 
The output format of older yojson was unstable in some cases.
@Julow Julow added the no changelog This pull request does not need a changelog entry label Oct 10, 2024
@Julow Julow mentioned this pull request Oct 10, 2024
Merged
@Julow
Copy link
Collaborator Author

Julow commented Oct 10, 2024

The snippet of JSON in test hidden_modules.t changes formatting several times between yojson 1.6.0 and 2.1.0 and has happened in the past #994
If this happens again, we might want to pipe our JSON outputs through jq.

@Julow
Copy link
Collaborator Author

Julow commented Oct 10, 2024

The lower-bound check is passing :)

@jonludlam
Copy link
Member

nice! thanks!

@jonludlam jonludlam merged commit 8f15caa into ocaml:master Oct 10, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no changelog This pull request does not need a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Julow @jonludlam