Skip to content

Conversation

gpetiot
Copy link
Collaborator

@gpetiot gpetiot commented Nov 7, 2024

Inspired by #1229 (comment)

Copy link
Collaborator

@panglesd panglesd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice solution.

let doc = "Show html-generate commands containing the string" in
Arg.(value & opt (some string) None & info [ "html-grep" ] ~doc)
let cmd =
let doc = "Opam mode" in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This manpage string can be made more explicit in #1229.

| Voodoo of { package_name : string; blessed : bool }
| Dune of { path : Fpath.t }
| Opam of { packages_dir : Fpath.t option }
| Opam of { packages : string list; packages_dir : Fpath.t option }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonludlam this is where the new argument libs will go in #1229

@jonludlam jonludlam added the no changelog This pull request does not need a changelog entry label Nov 8, 2024
@jonludlam
Copy link
Member

Cool thanks!

@jonludlam jonludlam merged commit 9d3d0d2 into ocaml:master Nov 8, 2024
13 of 14 checks passed
@gpetiot gpetiot deleted the split-driver-cmd branch November 8, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog This pull request does not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants