More module type of fixes #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonludlam
force-pushed
the
more-module-type-of-fixes
branch
from
08b4900 to
67b8501
Compare
Julow
approved these changes
Oct 28, 2020
When expanding `module type of` expressions we loop in case there's a nested instance of one. This adds some logic to avoid looping if there's no change in the signature, which can happen if the unexpanded module type of expression is in a different module. Signed-off-by: Jon Ludlam <jon@recoil.org>
Use the usual error types instead. Fixes ocaml#500 Signed-off-by: Jon Ludlam <jon@recoil.org>
These tests target the issues fixed in the previous few commits. Signed-off-by: Jon Ludlam <jon@recoil.org>
jonludlam
force-pushed
the
more-module-type-of-fixes
branch
from
67b8501 to
3192488
Compare
|
good question - might be worth looking over this in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #500 and a couple of other issues.