Remove hand-written compare and hash functions on paths #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julow
commented
Mar 1, 2021
|
|
||
| let compare x y = | ||
| match (x, y) with | ||
| | Internal (x, _), Internal (y, _) -> String.compare x y |
There was a problem hiding this comment.
Eliding this field was probably the reason of all this but I think this is not right because we use this function for data-structures, where this would be hazardous, and never intentionally for checking that two Internal have the same name.
Also, equal above uses ( = ).
Julow
force-pushed
the
cleanup-hash-compare
branch
from
2f4b810 to
df08828
Compare
|
Needs another rebase! |
This was eliding no fields and there is no data that can't be hashed by Hashtbl.hash.
Stdlib.compare can be used on these types.
Julow
force-pushed
the
cleanup-hash-compare
branch
from
df08828 to
9d1e074
Compare
|
Rebased. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No data need to be elided so
Stdlib.compareandHashtbl.hashcan be used.