Tweak ocp-indent config #637
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only fixes the most annoying case: match clauses. Ocp-indent doesn't offer enough options to fix this problem entirely.
Julow
commented
Mar 12, 2021
Comment on lines
2
to
3
| align_ops = false | ||
| align_params = never |
There was a problem hiding this comment.
These are unecessary because if they are ever useful (eg. breaking the line inside an expression), OCamlformat will reformat the whole thing differently anyway.
| # Auto-format the whole project using OCamlformat | ||
| 75efc08df487fa1a89fb86e446aadc8f6273b5bb | ||
| # ocamlformat 0.17.0 | ||
| b0c03d1b76f7da7d88d40bbc5029accfa9228112 |
There was a problem hiding this comment.
This feature of Git doesn't work well in my experience but it doesn't cost much to record these anyway.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only fixes the most annoying case: match clauses.
Ocp-indent doesn't offer enough options to fix this problem entirely (and that's fine because we shouldn't think about formatting now because of OCamlformat).
A lot of things are still not right: indentation inside a
(fun ...), long type constraints onlet, etc..