-
Notifications
You must be signed in to change notification settings - Fork 101
improve generator tests #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e5edd94
to
7f77d4d
Compare
1b5736b
to
85cbdfc
Compare
e9063eb
to
49ead72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
Latex tests are very noisy because of a debug print that should be removed:
diff --git a/src/latex/generator.ml b/src/latex/generator.ml
index 3abb962e..9626b055 100644
--- a/src/latex/generator.ml
+++ b/src/latex/generator.ml
@@ -62,7 +62,6 @@ module Link = struct
let filename url =
let dir = dir url in
let file = file url in
- Format.eprintf "dir=%a file=%s\n%!" Fpath.pp dir file;
if file = "" then Fpath.add_ext "tex" dir
else Fpath.(add_ext "tex" (dir / file))
end
|
ffe8131
to
3160bd6
Compare
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
30e94f3
to
0477357
Compare
4fb30d4
to
5768e21
Compare
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
5768e21
to
ad05e71
Compare
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
Ready for another review |
The v2 PR #697 looks much nicer, so closing this one! |
This PR is intended to fix #651.
Todo:
link.dune.inc.gen
and promoting it tolink.dune.inc
, the second for generating<html&latex&man>.dune.inc.gen
, and promoting them to<html&latex&man>.dune.inc
, and the third for generating and promoting output files (latex, html, and man-pages). In that sense, it makes more sense to wrap the series of test command under one command