Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add io.0.2.0 and nproc.0.5.1 #4774

Merged
merged 13 commits into from
Nov 25, 2015
Merged

Add io.0.2.0 and nproc.0.5.1 #4774

merged 13 commits into from
Nov 25, 2015

Conversation

rizo
Copy link
Contributor

@rizo rizo commented Sep 4, 2015

My first submission to the repository! :) Not sure what should happen next, though.

@camelus
Copy link
Contributor

camelus commented Sep 4, 2015

✅ All lint checks passed 9abc5e1
  • These packages passed lint tests: io.0.2.0, nproc.0.5.1

✅ Installability check (4167 → 4169)
  • new installable packages (2): io.0.2.0 nproc.0.5.1

@rizo
Copy link
Contributor Author

rizo commented Sep 4, 2015

Build scripts where missing in iter, added them now.

@avsm
Copy link
Member

avsm commented Sep 4, 2015

thanks for the fix -- have you pushed it though?

@rizo
Copy link
Contributor Author

rizo commented Sep 4, 2015

The problem was in one of the packages, so yes, I already updated it.

@avsm
Copy link
Member

avsm commented Sep 5, 2015

Still seems to be a build problem with a missing setup.ml -- need to run oasis setup?

@rizo
Copy link
Contributor Author

rizo commented Sep 5, 2015

Sorry, should be working now. Did a clean install to test.

authors: "Rizo Isrof <rizo@odis.io>"
homepage: "https://github.com/fold-lang/pratt-parser"
bug-reports: "https://github.com/fold-lang/pratt-parser/issues"
dev-repo: "https://github.com/fold-lang/pratt-parser"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should end with .git for opam to know it is a Git repository.

@rizo
Copy link
Contributor Author

rizo commented Sep 7, 2015

@Chris00, @avsm Thank you for your suggestions. I will update the oasis metadata definitions of all the packages and generate the corresponding opam files.

I have a question though: is there a way to install development packages? I know for local packages repo pinning can be used, but is there a way to force the latest master installation of a given package like in brew install ... --HEAD?

@rizo
Copy link
Contributor Author

rizo commented Sep 7, 2015

Another question: what is to be done when the package requires a library that cannot be installed with the operating system package managers? The ocaml-glfw requires libglfw3 but it's not present in apt repositories.

@Chris00
Copy link
Member

Chris00 commented Sep 7, 2015

You probably want to create a conf-libglfw3 that checks whether it exists on the system and, if not, either gives instructions to download it or downloads it and issue the proper commands to install in ~/.opam/<switch>/lib/stublibs/.

@Chris00
Copy link
Member

Chris00 commented Sep 7, 2015

Split $CAML_LD_LIBRARY_PATH for the later dir.

@samoht
Copy link
Member

samoht commented Sep 15, 2015

It's usually better to submit each package in a separate PR as it easier to identify individual errors. In that case iter and nproc seem to work fine.

For the external source not available in the old ubuntu distro, a somewhat hackish solution is to use the "source" depext: see

[["source" "linux"] ["https://gist.githubusercontent.com/domsj/9a28ba5a523a3420ded8/raw/dc6ebd8768a87dee285e84438dc733dfc58e037f/gistfile1.txt"]]
for instance. This is not pretty it works (at least for testing purposes)

@samoht
Copy link
Member

samoht commented Nov 3, 2015

ping?

@rizo
Copy link
Contributor Author

rizo commented Nov 5, 2015

Thanks for the ping @samoht, and sorry for the late reply!

Unfortunately currently I don't have time to add and test external dependency installation for ocaml-nanovg and ocaml-glfw. I think I'll remove them for now and add other libraries which already pass the validation.

Also I decided to rename iter to flow (https://github.com/rizo/flow) to reflect a wider domain of the library. But then I realised there already exists a package by @smondet with the same name (https://github.com/smondet/flow/), which seems to be deprecated.

I guess I'll have to come up with a new name and then finish this PR.

@rizo rizo changed the title Add iter.0.1.0-0, nproc.0.5.1, ocaml-glfw.0.1.0-0, pratt-parser.0.1.0-0 Add io.0.2.0 and nproc.0.5.1 Nov 19, 2015
@rizo
Copy link
Contributor Author

rizo commented Nov 20, 2015

I think everything's ready for review at this point.

avsm added a commit that referenced this pull request Nov 25, 2015
Add io.0.2.0 and nproc.0.5.1
@avsm avsm merged commit 8a9c69f into ocaml:master Nov 25, 2015
ejgallego added a commit to ejgallego/opam-repository that referenced this pull request Jun 29, 2021
…ator, dune-private-libs, dune and dune-build-info (2.9.0)

CHANGES:

- Add `(enabled_if ...)` to `(mdx ...)` (ocaml#4434, @emillon)

- Add support for instrumentation dependencies (ocaml#4210, fixes ocaml#3983, @nojb)

- Add the possibility to use `locks` with the cram tests stanza (ocaml#4480, @voodoos)

- Allow to set up merlin in a variant of the default context
  (ocaml#4145, @TheLortex, @voodoos)

- Add `(package ...)` to `(mdx ...)` (ocaml#4691, fixes ocaml#3756, @emillon)

- Handle renaming of `coq.kernel` library to `coq-core.kernel` in Coq 8.14 (ocaml#4713, @proux01)

- Fix generation of merlin configuration when using `(include_subdirs
  unqualified)` on Windows (ocaml#4745, @nojb)

- Fix bug for the install of Coq native files when using `(include_subdirs qualified)`
  (ocaml#4753, @ejgallego)

- Allow users to specify install target directories for `doc` and
  `etc` sections. We add new options `--docdir` and `--etcdir` to both
  Dune's configure and `dune install` command. (ocaml#4744, fixes ocaml#4723,
  @ejgallego, thanks to @JasonGross for reporting this issue)

- Fix issue where Dune would ignore `(env ... (coq (flags ...)))`
  declarations appearing in `dune` files (ocaml#4749, fixes ocaml#4566, @ejgallego @rgrinberg)

- Disable some warnings on Coq 8.14 and `(lang coq (>= 0.3))` due to
  the rework of the Coq "native" compilation system (ocaml#4760, @ejgallego)

- Fix a bug where instrumentation flags would be added even if the
  instrumentatation was disabled (@nojb, ocaml#4770)

- Fix ocaml#4682: option `-p` takes now precedence on environement variable
  `DUNE_PROFILE` (ocaml#4730, ocaml#4774, @bobot, reported by @dra27 ocaml#4632)

- Fix installation with opam of package with dune sites. The `.install` file is
  now produced by a local `dune install` during the build phase (ocaml#4730, ocaml#4645,
  @bobot, reported by @kit-ty-kate ocaml#4198)

- Fix multiple issues in the sites feature (ocaml#4730, ocaml#4645 @bobot, reported by @Lelio-Brun
  ocaml#4219, by @Kakadu ocaml#4325, by @toots ocaml#4415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants