Skip to content

Conversation

smorimoto
Copy link
Member

@smorimoto smorimoto commented Feb 21, 2023

Choosing a decent tar in the runners has been very difficult for us. So, we used to use tar from the MSYS environment quite aggressively in the Windows environment. Still, as the situation around them improved a little while I was away from my desk, now it's possible to use the cache library as it is.
https://github.com/actions/toolkit/blob/main/packages/cache/RELEASES.md#310

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto smorimoto added bug Something isn't working enhancement New feature or request labels Feb 21, 2023
@smorimoto smorimoto requested a review from dra27 February 21, 2023 00:38
Signed-off-by: Sora Morimoto <sora@morimoto.io>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto
Copy link
Member Author

Running on the default rails as much as possible is also a good way to prevent unexpected breaking...

Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested locally on my fork and on a repeat run of the workflow, actions/cache is clearly using the "correct" tar (from Git-for-Windows)

@smorimoto smorimoto merged commit 8ac9d30 into master Feb 21, 2023
@smorimoto smorimoto deleted the fix-windows-cache branch February 21, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Curl seem to be missing on Windows
2 participants