Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate ml.estimation.trunc.dist dependency on the "family" argument #20

Closed
3 of 4 tasks
wleoncio opened this issue Jan 22, 2021 · 2 comments
Closed
3 of 4 tasks
Assignees
Labels
enhancement New feature or request

Comments

@wleoncio
Copy link
Member

wleoncio commented Jan 22, 2021

Motivation

The ml.estimation.trunc.dist() function requires a family argument to manually trigger the appropriate estimation method. As of commit 8e17b33, this is not required anymore, because the y argument already contains this information in its class.

Steps

  • Remove family argument
  • If using S3: change name of ml.estimation.trunc.dist function to something without . (name can be kept for S4)
  • Split generic and methods for each signature
  • Adjust tests and examples
@wleoncio wleoncio added the enhancement New feature or request label Jan 22, 2021
@wleoncio wleoncio self-assigned this Jan 22, 2021
@wleoncio
Copy link
Member Author

wleoncio commented Jan 22, 2021

On further inspection, this might not even be necessary, given how the cases for family = seem to only contain functions that could be made into generics. Namely:

So if all those are made into generic functions, I think we can simply eliminate the family checks and leave the rest as is.

@wleoncio wleoncio changed the title Convert ml.estimation.trunc.dist into generic function Eliminate ml.estimation.trunc.dist dependency on the "family" argument Jan 22, 2021
@wleoncio
Copy link
Member Author

Points 2 and 3 from OP can be addressed later on their respective issue numbers.

wleoncio added a commit that referenced this issue Sep 6, 2021
Replaced naming convenction from dot-separated with camel case for better compatibility with S3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant