You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ml.estimation.trunc.dist() function requires a family argument to manually trigger the appropriate estimation method. As of commit 8e17b33, this is not required anymore, because the y argument already contains this information in its class.
Steps
Remove family argument
If using S3: change name of ml.estimation.trunc.dist function to something without . (name can be kept for S4)
Split generic and methods for each signature
Adjust tests and examples
The text was updated successfully, but these errors were encountered:
On further inspection, this might not even be necessary, given how the cases for family = seem to only contain functions that could be made into generics. Namely:
So if all those are made into generic functions, I think we can simply eliminate the family checks and leave the rest as is.
wleoncio
changed the title
Convert ml.estimation.trunc.dist into generic function
Eliminate ml.estimation.trunc.dist dependency on the "family" argument
Jan 22, 2021
Motivation
The
ml.estimation.trunc.dist()
function requires afamily
argument to manually trigger the appropriate estimation method. As of commit 8e17b33, this is not required anymore, because they
argument already contains this information in its class.Steps
ml.estimation.trunc.dist
function to something without.
(name can be kept for S4)The text was updated successfully, but these errors were encountered: