Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export density* functions as S3 methods of dtrunc #5

Closed
Tracked by #24
wleoncio opened this issue Jan 4, 2021 · 2 comments
Closed
Tracked by #24

Export density* functions as S3 methods of dtrunc #5

wleoncio opened this issue Jan 4, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@wleoncio
Copy link
Member

wleoncio commented Jan 4, 2021

This would require changing the class of the inputs of those files (y and eta) so they can be properly matched by the generic density() function. Otherwise, the functions won't work as methods for density().

@wleoncio wleoncio added the bug Something isn't working label Jan 4, 2021
@wleoncio wleoncio self-assigned this Jan 4, 2021
@wleoncio wleoncio changed the title Export density* functions as S3 methods Export density* functions as S3 methods of dtrunc Jan 5, 2021
@wleoncio
Copy link
Member Author

wleoncio commented Jan 5, 2021

After meeting, I understood the purpose of the density.* functions in this package a bit better. They should be methods of a generic dtrunc() function (to be created), drawing a parallel to the stats package's dnorm/rnorm functions. So this is unrelated to the generic density() functions.

@wleoncio wleoncio added enhancement New feature or request and removed bug Something isn't working labels Jan 5, 2021
@wleoncio
Copy link
Member Author

@rho62, could you please check if the documentation on R/dtrunc.R describing the function is correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant