Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply max length correctly and add test #660

Merged
merged 3 commits into from
Jun 21, 2024
Merged

fix: apply max length correctly and add test #660

merged 3 commits into from
Jun 21, 2024

Conversation

fernandozblu
Copy link
Collaborator

@fernandozblu fernandozblu commented Jun 21, 2024 •
edited
Loading

Description

  • CEP input was not sanitizing before sending the text to the callback event
  • Date input had 10 numbers of max length, instead of 8

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots (if appropriate):

@fernandozblu fernandozblu changed the title fix: aply max length correctly and add test fix: apply max length correctly and add test Jun 21, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@fernandozblu fernandozblu merged commit d8146bf into master Jun 21, 2024
2 checks passed
@fernandozblu fernandozblu deleted the fix-ocean-input-text-not-respecting-max-length branch June 21, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FariasBlu FariasBlu FariasBlu approved these changes

@mariofelesdossantosjunior mariofelesdossantosjunior Awaiting requested review from mariofelesdossantosjunior

@nordael nordael Awaiting requested review from nordael

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fernandozblu @FariasBlu