Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include fees in apy calculator #689

Conversation

KatunaNorbert
Copy link
Member

Fixes #683.

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
df-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 5:13pm

@KatunaNorbert KatunaNorbert changed the base branch from main to issue677-include-fees-inside-lock-screen-calculator November 30, 2023 06:33
Copy link
Contributor

@kdetry kdetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I removed some console logs and added a fix to the following PR. It could be better merge the following PR to this branch firstly

#693

@KatunaNorbert KatunaNorbert merged commit a1733f3 into issue677-include-fees-inside-lock-screen-calculator Dec 13, 2023
@KatunaNorbert KatunaNorbert deleted the issue683-add-fees-to-apy branch December 13, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update APY calculation to include fees
2 participants