-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use React #271
Comments
Or just make a react branch |
My view of the situation:
Obviously a React port is a good amount of effort, however using Gridsome just doesn't seem sustainable. React also has a richer ecosystem and more active community than Vue does. Finally, if we are to go forward with porting everything to React, a branch is probably necessary so that we can keep bugfixes going for the current version, since people do still use it for searching docs. However it would be a good idea to do a full feature freeze on master to avoid duplicate work, i.e. all "new" code goes to the React branch (which evenutally will get promoted to master). |
I think Ethan pretty much said it all, although also of note is the fact that more people are familiar with React both within the OCF and probably in Berkeley in general. I'm a little sad that we will never get svelte ocfweb but I think React is worth it for maintainability and ecosystem support. |
Just wanted to add we've hit more problems with Gridsome already: Node 17 broke webpack's hashing function, and a fix landed in webpack 5, however webpack maintainers have stated that it's not getting fixed for webpack 4. Meanwhile, a pull for webpack 5 in Gridsome has already been merged, however the last Gridsome release was a year ago (!!), so it has never been published. ...and of course more hydration problems have cropped up... |
How much would break if we removed Gridsome?
…On Mon, Nov 01, 2021 at 11:08 PM, Ethan Wu ***@***.***> wrote:
Just wanted to add we've hit more problems with Gridsome already: Node 17
broke webpack's hashing function, and a fix landed in webpack 5, however
webpack maintainers have stated that it's not getting fixed for webpack 4
<webpack/webpack#14532 (comment)>.
Meanwhile, a pull for webpack 5 in Gridsome
<gridsome/gridsome#1523> has already been merged,
however the last Gridsome *release* was a year ago (!!), so it has never
been published.
...and of course more hydration problems have cropped up...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#271 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQQGOCQHHYBNF45RIMEOHLTUJ555PANCNFSM5G33OA6A>
.
|
The only Gridsome-specific feature that I know of is the docs, since that uses Gridsome's data ingestion and then a search component. |
Completed (partially) in #325 |
We're using vue. Shall we use react instead?
Open for comments.
The text was updated successfully, but these errors were encountered: