Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

VSCode warns about using referenced projects without been composite #52

Open
VitorLuizC opened this issue Feb 9, 2022 · 0 comments · May be fixed by #53
Open

VSCode warns about using referenced projects without been composite #52

VitorLuizC opened this issue Feb 9, 2022 · 0 comments · May be fixed by #53

Comments

@VitorLuizC
Copy link

Screen Shot 2022-02-08 at 22 54 02

Every time a open the CLI package the VSCode warns me about an incorrect tsconfig.json that uses project references without having composite enabled. After looking at the docs I've confirmed that VSCode is right.

Link of TS's project references docs:
https://www.typescriptlang.org/docs/handbook/project-references.html#composite

Since tests/tsconfig.json is only used by test runner we don't see any error in the console, but for long term this may cause some troube.

VitorLuizC added a commit to VitorLuizC/hello-world that referenced this issue Feb 9, 2022
@VitorLuizC VitorLuizC linked a pull request Feb 9, 2022 that will close this issue
VitorLuizC added a commit to vuestorefront/vue-storefront that referenced this issue Feb 9, 2022
I've reported the errors in oclif's template repository and opened a PR
with the same fix used in this commit.

Issues:
oclif/hello-world#51
oclif/hello-world#52

PR:
oclif/hello-world#53
VitorLuizC added a commit to vuestorefront/vue-storefront that referenced this issue May 12, 2022
* chore: delete our current CLI package

* feat(core:cli): generate CLI package with oclif

But I had to remove the files ".editorconfig", "LICENSE" and
"yarn.lock" because we already have them in the
mono-repository and the folders ".circleci/" and ".github/"
that are specific to the oclif/hello-world repository.

* fix(core:cli): fix TS errors inherited from oclif

I've reported the errors in oclif's template repository and opened a PR
with the same fix used in this commit.

Issues:
oclif/hello-world#51
oclif/hello-world#52

PR:
oclif/hello-world#53

* chore(core:cli): use exact dependencies versions

* chore(core:cli): ignore "tsconfig.tsbuildinfo" file

* feat(core:cli): generate store init command

* chore(core:cli): remove template's commands

* feat(core:cli): add oclif hook that setups i18next

* fix(core:cli): setup i18next in the script instead of init hook

* feat(core:cli): use jest as test runner

* fix(core:cli): use CRLF in cmd files

* chore(core:cli): use our ESLint config instead of oclif's

* fix(core:cli): pack locales/ folder with our translations

* feat(core:cli): add generate store and integration commands

* feat(core:cli): move type and function to integration domain

* feat(core:cli): improve CLI's TS config

* fix(core:cli): fix ESLint breaking test script

* feat(core:cli): add git repository domain

* feat(core:cli): add git-repository-url domain

* fix(core:cli): fix broken test due to screen size

* feat(core:cli): add project-name domain

* feat(core:cli): add getIntegration to integration domain

* feat(core:cli): add theme domain and improve commands

* feat(core:cli): add translations for commands, inputs etc

* test(core:cli): fix tests broken bc translations

* feat(core:cli): add oclif's plugins

* fix(core:cli): support node 12

* fix(core:cli): fix broken test due to fs/promises usage

* chore(core:cli): bump to version 3.0.0

* fix(core:cli): remove generate README.md title and badges

* feat(core:cli): add identity and wait functions

* feat(core:cli): add BigCommerce option to CLI's integration list

Applies same change as in #6649.

* feat(core:cli): consume from integrations repository

* fix(core:cli): update integrations API URL

* fix(core:cli): remove unused short-circuit

* fix(cli): fix merge issues because of structural changes

* test(cli): fix wait unit test because of float inaccuracy

* chore(cli): upgrade dependencies

* feat(cli): show documentation link when available

* chore(cli): use rimraf instead of shx rm

* test(cli): add existsDirectory and removeFileOrDirectory tests

* feat(cli): add function to get directory from user input

* fix(cli): fix ENOENT when running inside monorepo

* impr(cli): improve generate store success message

* fix(cli): use require.resolve to get vsf-tu path

* chore(cli): run oclif readme in docs npm script

* chore(cli): upgrade dependencies

* chore(cli): upgrade dependencies and devDependencies

* fix(cli): fix directory not found error message

* impr(cli): add some line breaks after start command

* impr(cli): ask first for integration theme folder on generate template

* impr(cli): use better questions in generate template command

Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>

* chore(cli): keep dependencies and devDependencies update

* chore(cli): keep dependencies and devDependencies updated

Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant