Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

fix: move @oclif/errors from devDependencies to dependencies #71

Merged
merged 2 commits into from
Apr 27, 2020
Merged

fix: move @oclif/errors from devDependencies to dependencies #71

merged 2 commits into from
Apr 27, 2020

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Feb 14, 2020

What's the problem this PR addresses?

@oclif/parser uses @oclif/errors at runtime but doesn't declare it as a dependency, this causes Yarn in PnP mode to reject access to the package. When using node_modules this causes @oclif/parser to rely on hoisting which is not guaranteed to place it in a location where we can access it.

How did you fix it?

Moved @oclif/errors from devDependencies to dependencies

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @merceyz to sign the Salesforce.com Contributor License Agreement.

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #71 into master will decrease coverage by 91.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #71       +/-   ##
==========================================
- Coverage   91.38%   0.00%   -91.39%     
==========================================
  Files          11       1       -10     
  Lines         325      29      -296     
  Branches       86      14       -72     
==========================================
- Hits          297       0      -297     
- Misses         12      29       +17     
+ Partials       16       0       -16     
Impacted Files Coverage Δ
src/validate.ts 0.00% <0.00%> (-96.88%) ⬇️
src/deps.ts
src/parse.ts
src/util.ts
src/screen.ts
src/list.ts
src/errors.ts
src/help.ts
src/args.ts
src/index.ts
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e1a8be...4916575. Read the comment docs.

Copy link
Contributor

@RasPhilCo RasPhilCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄

Copy link
Contributor

@RasPhilCo RasPhilCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄

@RasPhilCo RasPhilCo merged commit ff28cec into oclif:master Apr 27, 2020
@merceyz merceyz deleted the errors branch April 28, 2020 06:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants