Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submenus don't have rounded corners #4788

Closed
invrainbow opened this issue Dec 6, 2021 · 2 comments
Closed

Submenus don't have rounded corners #4788

invrainbow opened this issue Dec 6, 2021 · 2 comments
Labels
menus menu bars, menu items style

Comments

@invrainbow
Copy link

invrainbow commented Dec 6, 2021 •
edited
Loading

The main menu has rounded corners as expected, but the side menu doesn't.

Edit: I feel dumb, turns out the main menu and child menu use different *Rounding style vars. Closing.
@ocornut ocornut added style menus menu bars, menu items labels Dec 21, 2021
@ocornut
Copy link
Owner

ocornut commented Dec 21, 2021 •
edited
Loading

From what I am saying it is exactly the opposite (tested on latest and before we made the recent menu changes) the first menu of a series is always square and following menus use ChildRounding. Should probably be fixed. (I guess we rarely expect ChildRounding to stay >0 it is more of a thing available for Push/Pop stack manipulation).

ocornut added a commit that referenced this issue Dec 21, 2021
@ocornut
Menus: fixed top-level menu from not consistently using style.PopupRo…
612b787 
…unding. (#4788)

+ Stack tool default size.
@ocornut
Copy link
Owner

ocornut commented Dec 21, 2021

Pushed a fix 612b787 to make top level menu and other sub-menu always use _PopupRounding consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
menus menu bars, menu items style
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ocornut @invrainbow