-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could you provide IsPopupOpen publicly? #799
Comments
Hello and sorry for my late answer.
I can't expose it in imgui.h just yet because popup ID are slightly misleading and problematic right now (in some instances using the ID stack - as currently - makes more sense, in some instances we'd want to ignore the id stack). Hence the unclosed discussion at #331, and I don't want to expose users relying on that subtly until it is sorted out. So it's just better now if you copy the function, at least you know you are in internals territory. You may want to call |
This is done now. In imgui.h In imgui_internal.h only The second one will probably be exposed later/soon along with other popup related functions, to help solving recurrent issues such as #331 #747 |
@ocornut How to call error: invalid conversion from ‘ImGuiID’ {aka ‘unsigned int’} to ‘const char*’ [-fpermissive]
1112 | ImGui::IsPopupOpen(w->PopupId)) {
| ~~~^~~~~~~
| |
| ImGuiID {aka unsigned int} |
This appears to cause an issue when compiling Open3D currently. Both imgui.h and imgui_internal.h are included and the compiler can't figure out which ImGui::IsPopupOpen() is being called. Is there a solution for this? |
@brad-colbert What compiler error are you getting? They should be distinct overloads. |
Just include |
@PathogenDavid gcc 11.3.0 (Ubuntu 22.04.01). "They should be distinct overloads." That's what I would expect but the compiler is complaining. Doesn't make sense to me. |
Please provide actual code and actual warnings so we don’t have to guess. |
Exactly the same as the original post: error: invalid conversion from ‘ImGuiID’ {aka ‘unsigned int’} to ‘const char*’ [-fpermissive] |
That error suggests imgui_internal.h is not included in the compilation unit giving out the error. |
I've been working on a variant of the radial menu you posted here, and it would help to know whether the Popup is actually open. There is a function IsPopupOpen in imgui.cpp, but it isn't exported publicly. Would you consider changing this?
The text was updated successfully, but these errors were encountered: