Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some RAII-style wrappers for windows, children, tree nodes, etc. #2197

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Add some RAII-style wrappers for windows, children, tree nodes, etc. #2197

wants to merge 19 commits into from

Conversation

sethk
Copy link

@sethk sethk commented Nov 18, 2018

As discussed in #2096, here is an additional header file with some RAII-style wrappers for common ImGui objects.

@sethk
Add some RAII wrappers for ImGui calls
5643330
@sethk
Put RAII header into a more appropriate location
47ba043
@sethk
ImGui::End() must always be called after Begin()
fb339a2
@sethk
Add some RAII wrappers for ImGui calls
9f7de90
@sethk
Put RAII header into a more appropriate location
5642908
@sethk
ImGui::End() must always be called after Begin()
4cad375
@sethk
Move RAII header into misc/cpp
542d8c8
@sethk
Use struct over class; all members are public
3583d64
@sethk
Delete the move and copy operators
ef8ec96
@sethk
Merge branch 'raii' into HEAD
f5b893d
@sethk
Get rid of duplicate renamed files
79e1aeb
@sethk
Wrap RAII helpers in namespace ImScoped
f42f3e6
@sethk
Generate wrappers for remaining Begin/Push/Tree methods
56374b8
@sethk
Use macro to delete copy/move constructors/operators
f7a2c93
@sethk
Make operator bool() explicit
e26b91d
@sethk
More thoroughly parse arguments and defaults
f61b727
@sethk
Rename imgui_raii -> imgui_scoped to match namespace
e6ff68a
@sethk
BeginGroup() and Tooltip don't have return values
0278610
@sethk
Assert that ImScoped::TreeNodeEx() is called without ImGuyTreeNodeFla…
0a25a49 
…gs_NoTreePushOnOpen
ocornut added a commit that referenced this pull request Nov 21, 2018
@ocornut
Added link to experimental imgui_scoped.h PR/thread (#2197, #2096)
a5cf227
hi-ogawa added a commit to hi-ogawa/toy-3d that referenced this pull request Dec 14, 2019
@hi-ogawa
imgui: rebase PR ocornut/imgui#2197
de6a49d
@ocornut ocornut mentioned this pull request Apr 22, 2021
Closed
@maxkunes maxkunes mentioned this pull request Jun 3, 2021
Open
@ocornut ocornut force-pushed the master branch 2 times, most recently from 0c1e5bd to bb6a60b Compare August 27, 2021 19:10
@ocornut ocornut force-pushed the master branch 2 times, most recently from 8b83e0a to d735066 Compare December 13, 2021 11:31
@ocornut ocornut force-pushed the master branch 2 times, most recently from b3b85d8 to 0755767 Compare January 17, 2022 14:21
@ocornut ocornut force-pushed the master branch 3 times, most recently from c817acb to 8d39063 Compare February 15, 2022 16:25
@ocornut ocornut mentioned this pull request May 9, 2023
Closed
@emoon emoon mentioned this pull request Oct 27, 2023
Closed
@ocornut ocornut mentioned this pull request Dec 18, 2023
Open
@learn-more
Copy link
Contributor

@sethk There are some generated classes that are outdated now:
PushAllowKeyboardFocus should be replaced with PushTabStop
BeginChildFrame could be replaced with BeginChild(..., ImGuiChildFlags_FrameStyle, ...);, or removed outright.
BeginPopupContextWindow does not take a boolean, but an ImGuiPopupFlags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cplusplus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sethk @learn-more @ocornut