Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan example fixes #785

Merged
merged 2 commits into from
Aug 20, 2016
Merged

Vulkan example fixes #785

merged 2 commits into from
Aug 20, 2016

Conversation

martty
Copy link
Contributor

@martty martty commented Aug 20, 2016

  • maxImageCount may be 0, means unlimited, handle this
  • add missing sType
  • change to using 1 push constant range, this results in the same functionality, but using 2 crashes my driver
    • using 2 ranges for 1 push constant block may or may not be valid, spec unclear (filed a bug against Vulkan spec to figure out)

@ocornut
Copy link
Owner

ocornut commented Aug 20, 2016

Thanks Martty. Could you replace the tabs by spaces and remove the braces where appropriate?

@martty
Copy link
Contributor Author

martty commented Aug 20, 2016

sorry, changed it!

@ocornut ocornut merged commit 4bc6a95 into ocornut:master Aug 20, 2016
@ocornut
Copy link
Owner

ocornut commented Aug 20, 2016

Thanks :)

@ocornut ocornut added the vulkan label Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants